Skip to content

Update encoding and line endings for consistency#932

Merged
axunonb merged 1 commit into
mainfrom
wip/axunonb/pr/enforce-utf8
Mar 17, 2026
Merged

Update encoding and line endings for consistency#932
axunonb merged 1 commit into
mainfrom
wip/axunonb/pr/enforce-utf8

Conversation

@axunonb
Copy link
Copy Markdown
Collaborator

@axunonb axunonb commented Mar 16, 2026

.editorconfig now enforces UTF-8 encoding for all files.
.gitattributes sets LF line endings and auto text normalization for C# files

.editorconfig now enforces UTF-8 encoding for all files.
.gitattributes sets LF line endings and auto text normalization for C# files
@sonarqubecloud
Copy link
Copy Markdown

@axunonb axunonb requested a review from maknapp March 16, 2026 21:46
@axunonb axunonb merged commit a1d1e8f into main Mar 17, 2026
12 checks passed
@axunonb axunonb deleted the wip/axunonb/pr/enforce-utf8 branch March 17, 2026 08:04
maknapp pushed a commit that referenced this pull request Mar 24, 2026
.editorconfig now enforces UTF-8 encoding for all files.
.gitattributes sets LF line endings and auto text normalization for C# files
@maknapp
Copy link
Copy Markdown
Collaborator

maknapp commented Apr 2, 2026

@axunonb I think auto line endings in gitattributes is making my local tests fail now. It seems some of the wiki tests depend on file line endings, and after git touches RecurrenceWikiTests.cs in Windows, the line endings are changed.

@axunonb
Copy link
Copy Markdown
Collaborator Author

axunonb commented Apr 2, 2026

iCalenders should use CRLF. But with the LF line endings the expected results don't fit because of raw strings. So

  • Either the wiki tests must normalize line endings before the assertions
  • or we remove the wiki tests altogether. We have the examples from the wiki tests as part of the wiki.

[Edit]
Fixed with #938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants